early-access version 2020

src/common/lru_cache.h

@@ -29,11 +29,11 @@ public:
     ~LeastRecentlyUsedCache() = default;
 
     size_t Insert(ObjectType obj, TickType tick) {
-        const auto new_id = build();
+        const auto new_id = Build();
         auto& item = item_pool[new_id];
         item.obj = obj;
         item.tick = tick;
-        attach(item);
+        Attach(item);
         return new_id;
     }
 
@@ -46,13 +46,13 @@ public:
         if (&item == last_item) {
             return;
         }
-        detach(item);
-        attach(item);
+        Detach(item);
+        Attach(item);
     }
 
     void Free(size_t id) {
         auto& item = item_pool[id];
-        detach(item);
+        Detach(item);
         item.prev = nullptr;
         item.next = nullptr;
         free_items.push_back(id);
@@ -80,11 +80,10 @@ public:
     }
 
 private:
-    size_t build() {
+    size_t Build() {
         if (free_items.empty()) {
             const size_t item_id = item_pool.size();
-            item_pool.emplace_back();
-            auto& item = item_pool[item_id];
+            auto& item = item_pool.emplace_back();
             item.next = nullptr;
             item.prev = nullptr;
             return item_id;
@@ -97,7 +96,7 @@ private:
         return item_id;
     }
 
-    void attach(Item& item) {
+    void Attach(Item& item) {
         if (!first_item) {
             first_item = &item;
         }
@@ -111,7 +110,7 @@ private:
         }
     }
 
-    void detach(Item& item) {
+    void Detach(Item& item) {
         if (item.prev) {
             item.prev->next = item.next;
         }
@@ -134,8 +133,8 @@ private:
 
     std::deque<Item> item_pool;
     std::deque<size_t> free_items;
-    Item* first_item;
-    Item* last_item;
+    Item* first_item{};
+    Item* last_item{};
 };
 
 } // namespace Common

src/common/settings.cpp

@@ -59,7 +59,6 @@ void LogSettings() {
     log_setting("Renderer_UseVsync", values.use_vsync.GetValue());
     log_setting("Renderer_ShaderBackend", values.shader_backend.GetValue());
     log_setting("Renderer_UseAsynchronousShaders", values.use_asynchronous_shaders.GetValue());
-    log_setting("Renderer_UseGarbageCollection", values.use_caches_gc.GetValue());
     log_setting("Renderer_AnisotropicFilteringLevel", values.max_anisotropy.GetValue());
     log_setting("Audio_OutputEngine", values.sink_id.GetValue());
     log_setting("Audio_EnableAudioStretching", values.enable_audio_stretching.GetValue());
@@ -143,7 +142,6 @@ void RestoreGlobalState(bool is_powered_on) {
     values.shader_backend.SetGlobal(true);
     values.use_asynchronous_shaders.SetGlobal(true);
     values.use_fast_gpu_time.SetGlobal(true);
-    values.use_caches_gc.SetGlobal(true);
     values.bg_red.SetGlobal(true);
     values.bg_green.SetGlobal(true);
     values.bg_blue.SetGlobal(true);

src/common/settings.h

@@ -481,7 +481,6 @@ struct Values {
                                                 ShaderBackend::SPIRV, "shader_backend"};
     Setting<bool> use_asynchronous_shaders{false, "use_asynchronous_shaders"};
     Setting<bool> use_fast_gpu_time{true, "use_fast_gpu_time"};
-    Setting<bool> use_caches_gc{false, "use_caches_gc"};
 
     Setting<u8> bg_red{0, "bg_red"};
     Setting<u8> bg_green{0, "bg_green"};